[feat] added priorityclass syncing from host #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
facchettos
force-pushed
the
priority-class-from-host
branch
from
0df84e9
to
ba45416
Compare
FabianKramm
reviewed
Aug 12, 2024
| priorityClass.GlobalDefault = false | ||
| if priorityClass.Value > 1000000000 { | ||
| priorityClass.Value = 1000000000 | ||
| } |
There was a problem hiding this comment.
Why are we doing these adjustments here, I know they are needed when going from virtual -> host, but in this case we could just leave them be, no?
FabianKramm
reviewed
Aug 12, 2024
| if translatedValue > 1000000000 { | ||
| translatedValue = 1000000000 | ||
| } | ||
| pObj.Value = translatedValue | ||
| targetObject.Value = translatedValue |
There was a problem hiding this comment.
I think we should only do this if syncing toHost, fromHost we don't mind the value
FabianKramm
reviewed
Aug 12, 2024
| if translatedValue > 1000000000 { | ||
| translatedValue = 1000000000 | ||
| } | ||
| targetObject.Value = translatedValue |
There was a problem hiding this comment.
Can you move that into the switch case and then exchange targetObject and sourceObject with the correct vObj and pObj?
facchettos
force-pushed
the
priority-class-from-host
branch
from
865f8d5
to
5598491
Compare
FabianKramm
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind feature
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves eng-4179
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster ...
What else do we need to know?