add --ca-cert flag to the vcluster platform add vcluster, so it can b… #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e used by passing .additionalCA from platform config
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
hidalgopl
force-pushed
the
add-hidden-ca-cert-flag-to-platform-add-vcluster
branch
from
bd17fd5
to
87054a4
Compare
hidalgopl
force-pushed
the
add-hidden-ca-cert-flag-to-platform-add-vcluster
branch
from
87054a4
to
1f55f06
Compare
FabianKramm
reviewed
Aug 14, 2024
| @@ -380,7 +380,7 @@ func (cmd *createHelm) addVCluster(ctx context.Context, vClusterConfig *config.C | |||
| return nil | |||
| } | |||
|
|
|||
| err = platform.ApplyPlatformSecret(ctx, cmd.LoadedConfig(cmd.log), cmd.kubeClient, "", cmd.Namespace, cmd.Project, "", "", false) | |||
| err = platform.ApplyPlatformSecret(ctx, cmd.LoadedConfig(cmd.log), cmd.kubeClient, "", cmd.Namespace, cmd.Project, "", "", false, cmd.LoadedConfig(cmd.log).Platform.CertificateAuthorityData) | |||
There was a problem hiding this comment.
Shouldn't this come from the flag? Why is this read from the config, while the other options are read from the flag?
There was a problem hiding this comment.
I'm not sure what's the preferred way to do this here.
I can change it for a flag, which will mean that vcluster create vcluster with driver helm will get a new flag. Do you think this should be a desired behavior?
FabianKramm
approved these changes
Aug 14, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
FabianKramm
added a commit
that referenced
this pull request
Aug 14, 2024
[v0.20] add --ca-cert flag to the vcluster platform add vcluster, so it can b… (#2046)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e used by passing .additionalCA from platform config
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)part of ENG-4224
Please provide a short message that should be published in the vcluster release notes
adds --ca-cert flag and adds
certificate-authority-datato the platform secret to enable secure connection between platform and vcluster. Overall behavior is described in this PRWhat else do we need to know?