Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate from host #2081

Merged
merged 2 commits into from
Aug 20, 2024
Merged

refactor: migrate from host #2081

merged 2 commits into from
Aug 20, 2024

Conversation

FabianKramm
Copy link
Member

@FabianKramm FabianKramm commented Aug 19, 2024 •
edited
Loading

What issue type does this pull request address? (keep at least one, remove the others)
/kind test

Changes:

  • Adds unit tests for mapper & recorder
  • Moved migrate from mapper to recorder
  • Migrate from host -> virtual before virtual -> host. This has the benefit that if naming is changed, the host object is seen first and the annotations such as NameAnnotation, NamespaceAnnotation etc can be used to correctly translate the object back to the virtual name as otherwise this could cause issues if we only migrate virtual -> host and assume wrong name mapping.

@netlify Netlify
Copy link

netlify bot commented Aug 19, 2024 •
edited
Loading

✅ Deploy Preview for vcluster-docs canceled.

Name Link
🔨 Latest commit b375983
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/66c440f2a71727000814a844

@FabianKramm FabianKramm changed the title test: add mapper test refactor: migrate from host Aug 19, 2024
@FabianKramm FabianKramm merged commit e5d0c6b into loft-sh:main Aug 20, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@FabianKramm