fallback to checking if config is in correct format #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
…egacy config in vcluster config convert Signed-off-by: Paweł Bojanowski <pawelbojanowski@protonmail.com>
hidalgopl
force-pushed
the
fix-vcluster-convert-config-already-migrated
branch
from
708af29
to
8caf63e
Compare
FabianKramm
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if we cannot unmarshal it into legacy config in vcluster config convert
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-4307
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster config convert fails even if valid config is provided
What else do we need to know?
I initially thought that we can return no error here, but I guess it may be confusing, as it will output an empty diff
{}.