[v0.20] revert adding --ca-data flag to vcluster platform add cluster #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hidalgopl
force-pushed
the
revert-adding-ca-data-flag
branch
from
97d3957
to
fa48bb2
Compare
Signed-off-by: Paweł Bojanowski <pawelbojanowski@protonmail.com>
hidalgopl
force-pushed
the
revert-adding-ca-data-flag
branch
from
fa48bb2
to
b86e6d8
Compare
deniseschannon
changed the title
FabianKramm
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after changes made in https://github.com/loft-sh/loft-enterprise/pull/3187 ,
--ca-dataflag invcluster platform add clusteris redundant; it's actually better if user can configure additionalCA once for platform, and then connected clusters will automatically use it, instead of forcing user to pass it to thevcluster platform add clustercommand every single time.It reverts #2159 but keeps
--ca-dataflag forplatform add vclustercommands visible