revert adding --ca-data flag to vcluster platform add cluster #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
FabianKramm
approved these changes
Sep 19, 2024
Signed-off-by: Paweł Bojanowski <pawelbojanowski@protonmail.com>
hidalgopl
force-pushed
the
revert-adding-ca-data-flag-to-add-cluster
branch
from
363a0c3
to
9018b43
Compare
FabianKramm
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after changes made in https://github.com/loft-sh/loft-enterprise/pull/3187 , --ca-data flag in vcluster platform add cluster is redundant; it's actually better if user can configure additionalCA once for platform, and then connected clusters will automatically use it, instead of forcing user to pass it to the vcluster platform add cluster command every single time.
It reverts #2153 but keeps --ca-data flag for platform add vcluster commands visible