Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pv syncing #2178

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix: pv syncing #2178

merged 1 commit into from
Sep 24, 2024

Conversation

FabianKramm
Copy link
Member

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves ENG-4679

Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for vcluster-docs canceled.

Name Link
🔨 Latest commit a7928fc
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/66f335efb370e800084a2f12

Copy link
Contributor

@rmweir rmweir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is needing the req.Name fallback going to common? If so could we just add this option to generic mapper or make a mapper for this purpose?

@FabianKramm FabianKramm merged commit 359b6e5 into loft-sh:main Sep 24, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants