Fix intermediate integer overflow when reading/writing large files #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed issue with intermediate integer overflow when writing files exceeding 2 GB
TRPrasanna
changed the title
multiplied 1_AddrInt to wherever variable offsetIO is used
|
I just realized that overflow can happen at more places, basically wherever the variable offsetIO is multiplied by other integers. So I multiplied these terms with 1_AddrInt wherever this variable exists on the right hand side of any relevant expression, so that the product is promoted to type AddrInt. These were only in 2 more lines (line 3081 and 3377, in addition to the first commit for line 2981). |
TRPrasanna
changed the title
oscarmarino
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed issue with intermediate integer overflow when writing files exceeding 2 GB
see here : #223