Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI command list #157

Closed
shreyashankar opened this issue May 13, 2021 · 6 comments · Fixed by #223
Closed

CLI command list #157

shreyashankar opened this issue May 13, 2021 · 6 comments · Fixed by #223
Assignees
Labels
good first issue Good for newcomers M Medium difficulty to complete (could take a day)

Comments

@shreyashankar
Copy link
Collaborator

shreyashankar commented May 13, 2021

Currently we have:

  • recent
  • history
  • trace

We would also like to include:

  • inspect COMPONENT_RUN_ID
  • ls tags
  • ls components
  • ls components --tag=TAG
  • ls components --owner=NAME

We can use get_components_for_owner and get_components_for_tag to make the ls commands.

@shreyashankar shreyashankar added the M Medium difficulty to complete (could take a day) label May 13, 2021
@shreyashankar
Copy link
Collaborator Author

Also include DB migration as a command

@ariG23498 ariG23498 mentioned this issue May 15, 2021
5 tasks
@shreyashankar
Copy link
Collaborator Author

On second thought, maybe ls is not the command to use. Maybe:

  • mltrace tags
  • mltrace components
  • mltrace components --tag=TAG
  • mltrace components --owner=NAME

Where the output of each of these commands is just a list of tags or components, one item per line.

@ariG23498
Copy link
Contributor

I think this is a better CLI design. This aligns well with what we have now. I can work on this and put up a draft for the same. We can later discuss how this pans out and what needs to be changed.

@shreyashankar shreyashankar added the good first issue Good for newcomers label Aug 30, 2021
@shreyashankar
Copy link
Collaborator Author

@aditim1359 is working on this

@aditim1359
Copy link
Collaborator

What exactly should "mltrace tags" be doing? Displaying all tags in use for all components?

@shreyashankar
Copy link
Collaborator Author

Yes -- a tag can be associated with many components. No point in filtering tags by component because we could just call mltrace components --tag=TAG for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers M Medium difficulty to complete (could take a day)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants