Adds new CLI features and IOPointer unflag all option #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto clifeatures
…nto clifeatures
shreyashankar
requested changes
Sep 8, 2021
|
The reason the tests are failing are because of it testing te functionality of the get_components_with_owner function which I condensed into get_components. Are there any other things off the top of your head that need the get_components_with_owner and with_tag separate functions? if so, I can update them or we can discuss. Otherwise, I will update those tests to just test for get_components. |
|
Your solution sounds good to me! I don't think there are any dependencies on the old functions |
shreyashankar
requested changes
Sep 10, 2021
added 2 commits
September 10, 2021 10:50
shreyashankar
changed the title
shreyashankar
approved these changes
Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed the cli features: addd ml trace tags, components and unflag all
Closes #203
Closes #157