-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds new CLI features and IOPointer unflag all option #223
Conversation
…nto clifeatures
…nto clifeatures
The reason the tests are failing are because of it testing te functionality of the get_components_with_owner function which I condensed into get_components. Are there any other things off the top of your head that need the get_components_with_owner and with_tag separate functions? if so, I can update them or we can discuss. Otherwise, I will update those tests to just test for get_components. |
Your solution sounds good to me! I don't think there are any dependencies on the old functions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super close! Just a couple of nits & one method stub to fill out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So close!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Feel free to merge :)
Addressed the cli features: addd ml trace tags, components and unflag all
Closes #203
Closes #157