Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove orphaned files/blocks from db when comparing db && disk #7686

Merged
merged 3 commits into from
Dec 14, 2022
Merged

fix: remove orphaned files/blocks from db when comparing db && disk #7686

merged 3 commits into from
Dec 14, 2022

Conversation

tiensonqin
Copy link
Contributor

@tiensonqin tiensonqin commented Dec 12, 2022 •
edited
Loading

To reproduce:

  1. Create a page odroid-c2 with the content: 
    alias:: Board/ODROID-C2
title:: odroid-c2
  2. Rename odroid-c2 to ODROID-C2
  3. Cmd+R to refresh the app

An error similar to Page already exists will be notified.

@tiensonqin tiensonqin force-pushed the fix/remove-deleted-files-from-db branch from 4eb4c43 to 44edd2f Compare December 13, 2022 04:42
cnrpman
cnrpman approved these changes Dec 13, 2022
View reviewed changes
Copy link
Collaborator

@cnrpman cnrpman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andelf
Copy link
Collaborator

andelf commented Dec 13, 2022 •
edited
Loading

The entire UI freezes and becomes unresponsive when a file is externally renamed (changing the case of the letters).
image

image

@tiensonqin tiensonqin force-pushed the fix/remove-deleted-files-from-db branch from 44edd2f to da790bc Compare December 14, 2022 04:36
andelf
andelf approved these changes Dec 14, 2022
View reviewed changes
Copy link
Collaborator

@andelf andelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andelf andelf merged commit b6061f0 into master Dec 14, 2022
@andelf andelf deleted the fix/remove-deleted-files-from-db branch December 14, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnrpman cnrpman cnrpman approved these changes

@andelf andelf andelf approved these changes

@RCmerci RCmerci Awaiting requested review from RCmerci

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiensonqin @andelf @cnrpman