Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding docker support + some documentation fixes/additions #4

Closed
wants to merge 6 commits into from

Conversation

MathiasVDA
Copy link

Hello, I'm a fan of rdf-export!

This MR contains a dockerfile and changes to the github actions to automate deployment.

It also contains additional documentation on how to use the docker image + a fix for an issue that I discovered in the readme file (for the config file location).

I currently host a dockerimage on dockerhub for this tool, but if you are going to support it, then I will remove the image. In that case, the documentation will also need to be adapted to point to the official docker image.

In order for the github action to work, two secrets need to be added here: https://github.com/logseq/rdf-export/settings/secrets/actions

  • DOCKER_PASSWORD
  • DOCKER_USERNAME

@logseq-cldwalker logseq-cldwalker added the awaiting response Issue will be closed if a reply is not received label Oct 21, 2024
@logseq-cldwalker
Copy link
Contributor

Hi. Thanks for your interest in contributing. However this repo is meant to be meant lightweight and I'm not looking to pull in docker as an additional approach to maintain. I think having this as a separate repo would be helpful to the community and encourage this feature to be maintained by those who are actively using it. I'd be happy to link to your repo in the readme and ping you if I'm aware of dependencies that require updating. See logseq/publish-spa#29 as an example of another logseq github action that has already done this

@MathiasVDA
Copy link
Author

Ok no problem, I actually would have felt bad just creating a repository to convert your work into a docker image. It would have felt like stealing. But now that you suggest it, I don't mind at all to offer the support.

You can refer to this repo: https://github.com/Matdata-eu/logseq-rdf-export-docker

Please do look at this commit: 497b845#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L107 this part:
image

It would be good if you fixed this in your documentation.

@logseq-cldwalker
Copy link
Contributor

logseq-cldwalker commented Oct 22, 2024

Great! Thanks for extending rdf-export's functionality and being a part of our community. I've mentioned it in the readme

It would be good if you fixed this in your documentation.

Fixed

logseq-cldwalker added a commit that referenced this pull request Oct 22, 2024
logseq-cldwalker added a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response Issue will be closed if a reply is not received
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants