Deprecate document_type option #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM
On Tue, Nov 7, 2017 at 9:32 PM DeDe Morton ***@***.***> wrote:
Plugin doc changes related to
logstash-plugins/logstash-output-elasticsearch#691
<logstash-plugins/logstash-output-elasticsearch#691>
Adds statement indicating that document_type is deprecated.
Also removed the note about setting the type option because I am moving
that content to the section about the config option, where it will be
conditionally coded to only appear in the docs for the beats input plugin.
(Note that the changes in this PR are related to elastic/logstash#8603
<elastic/logstash#8603>)
------------------------------
You can view, comment on, or merge this pull request online at:
#267
Commit Summary
- Deprecate document_type option
File Changes
- *M* CHANGELOG.md
<https://github.com/logstash-plugins/logstash-input-beats/pull/267/files#diff-0>
(3)
- *M* VERSION
<https://github.com/logstash-plugins/logstash-input-beats/pull/267/files#diff-1>
(2)
- *M* docs/index.asciidoc
<https://github.com/logstash-plugins/logstash-input-beats/pull/267/files#diff-2>
(13)
Patch Links:
-
https://github.com/logstash-plugins/logstash-input-beats/pull/267.patch
-
https://github.com/logstash-plugins/logstash-input-beats/pull/267.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#267>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAACgLe0Uf55zHx9NQhz6iZbJgmjCACKks5s0RLSgaJpZM4QVweS>
.
--
ph
|
dedemorton
force-pushed
the
deprecate_document_type
branch
from
91206b9 to
46aea2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin doc changes related to logstash-plugins/logstash-output-elasticsearch#691
Adds statement indicating that document_type is deprecated.
Also removed the note about setting the
typeoption because I am moving that content to the section about the config option, where it will be conditionally coded to only appear in the docs for the beats input plugin.(Note that the changes in this PR are related to elastic/logstash#8603)