Add settings to connect to Salesforce MyDomain url #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to restforce v5 for compatibility with faraday v1.x in Logstash v7.15.x
|
Fixes #16 |
robbavey
requested changes
Oct 25, 2021
Raise a ConfigurationError if both use_test_sandbox and sfdc_instance_url are configured. These two options are mutually exclusive.
mkreth
commented
Nov 2, 2021
robbavey
requested changes
Nov 2, 2021
There was a problem hiding this comment.
Code looks great! Thank you for the contribution and your patience. I have a request on the docs, although I will pass over to @karenzone for a final review on documentation.
Would you mind incrementing the version in the gemspec file, and adding a note in the changelog explaining the change? As we are adding a new feature to the plugin, we should make this a minor update with the new version 3.1.0
Thanks again!
karenzone
reviewed
Nov 2, 2021
karenzone
approved these changes
Nov 9, 2021
robbavey
approved these changes
Nov 11, 2021
|
This plugin has been released as version |
|
Hi @karenzone, @robbavey, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which use case is this pull request trying to solve
We are operating in an environment where we need to explicitly put Salesforce IPs into an allow-list to be able to connect. We are pushed to limit the number of IPs that we are requesting. For us it would hence be helpful to narrow down the number of IPs that we need to connect to. For this we would like more control over which Salesforce endpoint is used by the Salesforce input plugin for authentication and for further API requests. The latter would usually go to the instance url which is returned by the login request. The login request would always go to either login.salesforce.com or test.salesforce.com (depending on the value of the
use_test_sandboxsetting).What does this pull request do
This pull request introduces a new configuration setting of the Salesforce input plugin which allows to provide the Salesforce instance url to connect to (already) for authentication and further API requests. The configuration parameter is named
sfdc_instance_urland takes a string value of the form<mydomain>.my.salesforce.com, e.g. the hostname part of the instance url without protocol or path.If a
sfdc_instance_urlis given, it takes precedence over theuse_test_sandboxsetting and controls the endpoint to which the login request is sent.If
sfdc_instance_urlis not set, then theuse_test_sandboxsetting will control which endpoint is used.