interval: only sleep off remainder #100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to adhere to the interval, regardless of how long execution takes.
After executing, sleep off only the remainder of the interval (if any), and
log a helpful warning when execution takes longer than the interval.
Release notes
Fixes issues related to fetching SNMP data at a periodic interval. The plugin now only sleeps off the remainder of the interval between runs, and logs a helpful warning when execution takes longer than the configured interval.
What does this PR do?
Introduces and tests a new
StoppableIntervalRunner
, which is used to run the crawler at a periodic interval. The implementation respects the stop-status of the plugin, and uses the plugin's logger to warn when execution takes longer than the configured interval.Why is it important/What is the impact to the user?
Ensures that the
interval
option supports actually collecting SNMP data at that periodic interval. When this plugin is configured with a 5-minute interval (interval => 300
), and a number of hosts that take anywhere from 3-seconds to 1-minute to fetch data from, this ensures that the start of each crawl is correctly 5-minutes apart.Checklist
[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Related issues
Resolves: #61
Logs
When the interval cannot be satisfied, a helpful log message is emitted: