Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI failures. #113

Merged
merged 5 commits into from
Jun 30, 2023
Merged

Fix CI failures. #113

merged 5 commits into from
Jun 30, 2023

Conversation

mashhurs
Copy link
Contributor

@mashhurs mashhurs commented Jun 27, 2023 •
edited
Loading

Description

This PR fixes multiple issues CI is having.

  1. Fix cannot access class error:
Exception in thread "Ruby-0-Thread-3: :1" java.lang.IllegalAccessError: class com.google.googlejavaformat.java.JavaInput 
(in unnamed module @0x677d4cea) cannot access class com.sun.tools.javac.parser.Tokens$TokenKind (in module 
jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.parser to unnamed module @0x677d4cea
  1. Integration and unit test failures due to 8.x version ECS default enabled feature.

@mashhurs mashhurs mentioned this pull request Jun 28, 2023
Merged
@mashhurs mashhurs changed the title Use common CI docker-compose.yml. Fix CI failures. Jun 29, 2023
@mashhurs mashhurs marked this pull request as ready for review June 29, 2023 14:40
@mashhurs mashhurs requested a review from kaisecheng June 29, 2023 18:46
@mashhurs mashhurs mentioned this pull request Jun 29, 2023
Closed
@mashhurs mashhurs self-assigned this Jun 29, 2023
robbavey
robbavey approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mashhurs mashhurs merged commit b6ad0f9 into main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbavey robbavey robbavey approved these changes

@kaisecheng kaisecheng Awaiting requested review from kaisecheng

Assignees

@mashhurs mashhurs

Labels
Test Failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI test failures with 8.x versions.
2 participants
@mashhurs @robbavey