add missing coercions #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvd
reviewed
Jun 14, 2018
| def coerce(variable) | ||
| variable_syntax = variable.getSyntax | ||
| # puts("variable.getSyntaxString=#{variable.getSyntaxString}") | ||
| case variable_syntax | ||
| when BER::OCTETSTRING | ||
| when BER::OCTETSTRING, BER::BITSTRING |
There was a problem hiding this comment.
is there any place we can find the whole list of possible options?
There was a problem hiding this comment.
webmat
approved these changes
Jun 14, 2018
| def coerce(variable) | ||
| variable_syntax = variable.getSyntax | ||
| # puts("variable.getSyntaxString=#{variable.getSyntaxString}") | ||
| case variable_syntax | ||
| when BER::OCTETSTRING | ||
| when BER::OCTETSTRING, BER::BITSTRING |
There was a problem hiding this comment.
You have a require for java_import "org.snmp4j.smi.OctetString". Do you need to add one for BitString as well?
Actually I see you don't have requires for the counters. Ok, I guess I don't have enough context here :-)
There was a problem hiding this comment.
Yeah I figured out that it's probably coming from the asn1.BER import. Never mind :-)
There was a problem hiding this comment.
the OctetString class is required for the build_target method - not needed for the coercion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11
This adds some missing coercions for
BITSTRING,COUNTER64andNULL.Tested manually locally, no spec coverage for this yet (working on it for larger
Clientclass specs.