Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve syntax coercion #32

Merged
merged 2 commits into from
Oct 11, 2018
Merged

improve syntax coercion #32

merged 2 commits into from
Oct 11, 2018

Conversation

colinsurprenant
Copy link
Contributor

fixes #31

  • adds a handler for BER::NOSUCHINSTANCE
  • logs error instead of raising exception for unhandled syntax
  • related specs

@colinsurprenant colinsurprenant mentioned this pull request Oct 11, 2018
Closed
@colinsurprenant
Copy link
Contributor Author

I decided to log instead of crashing of unsupported syntax, let me know if you think we should do otherwise @axrayn !

guyboertje
guyboertje approved these changes Oct 11, 2018
View reviewed changes
Copy link

@guyboertje guyboertje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinsurprenant colinsurprenant merged commit 6781cbc into logstash-plugins:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guyboertje guyboertje guyboertje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need coerce handler for syntax 129
2 participants
@colinsurprenant @guyboertje