Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate general input option vs SNMPv3 specific options #38

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

colinsurprenant
Copy link
Contributor

followup on #36

@colinsurprenant
Copy link
Contributor Author

LMKWYT @karenzone!

@axrayn
Copy link
Contributor

axrayn commented Oct 29, 2018

Should there be a reference to setting 'aes' being equivalent to setting 'aes128' just so there's no doubt/confusion?

@colinsurprenant
Copy link
Contributor Author

@axrayn good point. will do. thanks!

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@karenzone
Copy link
Contributor

@colinsurprenant I still need to make changes to support no_codec conditional, so I can bump versions at that time if that works for you.

@colinsurprenant
Copy link
Contributor Author

@karenzone sure - works for me. I will then just add a changelog commit without version, you can adjust when you bump.

@colinsurprenant colinsurprenant merged commit 8839575 into logstash-plugins:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants