Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no_codec condition to the doc and bump version #39

Closed
wants to merge 2 commits into from

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone commented Nov 1, 2018

Added no_codec tag to doc and removed comment //Verify default codec
Included fix for #40 to add SNMP versions and protocols

@karenzone
Copy link
Contributor Author

@colinsurprenant I'd like to get your eyes on this. Note that I'll need to get all the plumbing in place to support conditional coding before we can merge. Thanks!

@karenzone
Copy link
Contributor Author

@colinsurprenant @acchen97 I added fix for #40 to this PR.

@@ -26,6 +24,8 @@ include::{include_path}/plugin_header.asciidoc[]
The SNMP input polls network devices using Simple Network Management Protocol (SNMP)
to gather information related to the current state of the devices operation.

The SNMP input plugin supports SNMP v1, v2c, and v3 over UDP and TCP transport protocols.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @karenzone 👍

@elasticsearch-bot
Copy link

karen.metts merged this into the following branches!

Branch Commits
master 6f9e295, 882af39

elasticsearch-bot pushed a commit that referenced this pull request Nov 3, 2018
@karenzone karenzone deleted the no-codec branch November 3, 2018 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants