Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: scope and review java_imports #72

Merged
merged 2 commits into from
Mar 16, 2020

Conversation

kares
Copy link
Contributor

@kares kares commented Mar 13, 2020

Copy link
Contributor

@colinsurprenant colinsurprenant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinsurprenant
Copy link
Contributor

The build failure seems unrelated and only happens on master, something about the logger. I've seen other instances too. 🤔

@kares kares merged commit d6878c8 into logstash-plugins:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants