Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize Dependencies #116

Merged
merged 14 commits into from
Aug 7, 2024
Merged

Conversation

versecafe
Copy link
Contributor

This moves all dependencies to their newest stable release and updates any deprecations with two exceptions being serialize-error and stack-trace both of which have some CJS compatibility issues, @msgpack/msgpack is on the latest non beta release

@msgpack/msgpack 2.8.0   2.8.0  3.0.0-beta2 @logtail/edge dependencies https://msgpack.org/
@msgpack/msgpack 2.8.0   2.8.0  3.0.0-beta2 @logtail/node dependencies https://msgpack.org/
serialize-error  8.1.0   8.1.0  11.0.3      @logtail/core dependencies https://github.com/sindresorhus/serialize-error#readme
serialize-error  8.1.0   8.1.0  11.0.3      @logtail/edge dependencies https://github.com/sindresorhus/serialize-error#readme
serialize-error  8.1.0   8.1.0  11.0.3      @logtail/node dependencies https://github.com/sindresorhus/serialize-error#readme
stack-trace      0.0.10  0.0.10 1.0.0-pre2  @logtail/edge dependencies https://github.com/felixge/node-stack-trace
stack-trace      0.0.10  0.0.10 1.0.0-pre2  @logtail/node dependencies https://github.com/felixge/node-stack-trace

This also comes with Lerna + Nx which improves caching, features like lerna bootstrap are no longer needed they work directly within the pm making dependency tracking easier and creating a singular lock file, and plenty of other small changes to things such as formatting behaviors, performance, compatibility, etc.

Breaking Changes

  • No end user breaking changes
  • CI for Node 16.x is no longer functional as Lerna v7 and on do not support anything below 18.x, but the end packages are 16.x compatible

@versecafe
Copy link
Contributor Author

@PetrHeinz Can you give this a review when you have some time, thank you.

@PetrHeinz
Copy link
Member

Thank you @versecafe for the PR and for your patience with the review. I really appreciate the work, description and commit separation. That should make the review easier for me 🙌

@versecafe
Copy link
Contributor Author

@PetrHeinz Sorry for the ping, any update on the review?

@PetrHeinz
Copy link
Member

Hi @versecafe, thanks for the ping 🙌 I got a few higher priority tasks ahead at the moment, so I can't really provide any ETA.

Thanks for understanding, your patience, and for the effort that went into the PR, I really appreciate it 🙏

@versecafe
Copy link
Contributor Author

Thanks for the update, No rush just wanted to know if it was dropped as stale or only put on hold as lower priority.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@PetrHeinz
Copy link
Member

Hi @versecafe, thanks for your patience 🙏

I've reviewed and tested the changes, I believe we're good to go for v0.5.0 with this change 👍 Just made two tweaks to the changes.

Thank you very much for taking the time and effort to improve the library! 🙌

@PetrHeinz PetrHeinz merged commit ce3ed55 into logtail:master Aug 7, 2024
4 checks passed
@PetrHeinz
Copy link
Member

v0.5.0 released and re-tested, everything works just nicely 🎉

Thanks a lot, @versecafe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants