-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize Dependencies #116
Conversation
@PetrHeinz Can you give this a review when you have some time, thank you. |
Thank you @versecafe for the PR and for your patience with the review. I really appreciate the work, description and commit separation. That should make the review easier for me 🙌 |
@PetrHeinz Sorry for the ping, any update on the review? |
Hi @versecafe, thanks for the ping 🙌 I got a few higher priority tasks ahead at the moment, so I can't really provide any ETA. Thanks for understanding, your patience, and for the effort that went into the PR, I really appreciate it 🙏 |
Thanks for the update, No rush just wanted to know if it was dropped as stale or only put on hold as lower priority. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
Hi @versecafe, thanks for your patience 🙏 I've reviewed and tested the changes, I believe we're good to go for Thank you very much for taking the time and effort to improve the library! 🙌 |
Thanks a lot, @versecafe! |
This moves all dependencies to their newest stable release and updates any deprecations with two exceptions being
serialize-error
andstack-trace
both of which have some CJS compatibility issues,@msgpack/msgpack
is on the latest non beta releaseThis also comes with Lerna + Nx which improves caching, features like lerna bootstrap are no longer needed they work directly within the pm making dependency tracking easier and creating a singular lock file, and plenty of other small changes to things such as formatting behaviors, performance, compatibility, etc.
Breaking Changes