Call logtail.flush() when LogtailTransport (winston) is closed #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetrHeinz
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Hello @mutaflux, and thank you for taking your time with your contribution 🙏
Excellent work on describing the issue, fixing it, and even providing a test 🚀
I've just verified the test fails as expected, and ran lint. I'll release it as v0.4.23 shortly. Thanks again, much appreciated!
|
New |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started using
@logtail/nodewithwinstonand noticed that when a winston logger closes,LogtailTransportdoes not flush buffered messages tologtail. This is especially annoying when trying to log unhandled exceptions that cause the process to exit.The base winston
Transportclass accepts aclose()callback in the constructor options object, which is called whenever the transport instance is "unpiped" from the logger. This PR wraps anyclose()callback passed to the constructor ofLogtailTransportwith the flushing logic.This PR also adds a unit test for
LogtailTransport. This test fails without the changes in the constructor.