feat(core): add more options for sign-in uri generation #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangsijie
approved these changes
Sep 6, 2024
Base automatically changed from
xiaoyijun-refactor-introduce-generate-sign-in-uri-options
to
master
September 6, 2024 02:55
xiaoyijun
force-pushed
the
xiaoyijun-feat-add-options-for-sign-in-uri-generation
branch
from
71816a4
to
a4ffe2c
Compare
xiaoyijun
deleted the
xiaoyijun-feat-add-options-for-sign-in-uri-generation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add more options for sign-in uri generation in core sdk to align with other SDKs.
These options are used to generate query params in sign-in uri:
loginHint:login_hintfirstScreen:first_screenidentifier:identifierThe
extraParamsoption is used to generate extra params in the sing-in uri.The
includeReservedScopesoption is used to control if the reserved scopes (openid,offline_accessandprofile) is present in the sign-in uri.Testing
UT and test locally.
Checklist
.changeset