update better-sqlite3 #1465
Merged
update better-sqlite3 #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolopinto
force-pushed
the
update-better-sqlite3
branch
3 times, most recently
from
23c82ea to
b82daa2
Compare
lolopinto
force-pushed
the
update-better-sqlite3
branch
from
4866c48 to
c3863e2
Compare
lolopinto
force-pushed
the
update-better-sqlite3
branch
from
3aadd8f to
da14a57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update
better-sqlite3to latest versionfixes #1278
I believe sporadic error i was seeing was related to jest WiseLibs/better-sqlite3#162
2 changes to make tests passe:
instanceof Errorchecks, also check the constructor's name isSqliteErrorexpect(promise).rejects. do a try/catchalso, adds WAL pragma as recommended in the README