client: remove public class fields #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JavaScript public field declarations are not supported in Safari versions
lower than 14.1. This caused problems on iPhone 6 and iPad mini 2.
This patch replaces all public field declarations with simple, object scoped
variables, set from the constructor, and replaces the `Lona` class, used as
a global namespace, with an object of the class `LonaNamespace`.
The renaming was done to prevent naming collisions between the class, and the
global object.
Further readings:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Public_class_fields#browser_compatibility
Signed-off-by: Florian Scherf <mail@florianscherf.de>
JavaScript public field declarations are not supported in Safari versions
lower than 14.1. This caused problems on iPhone 6 and iPad mini 2.
This patch replaces all public field declarations with simple, object scoped
variables, set from the constructor, and replaces the `Lona` class, used as
a global namespace, with an object of the class `LonaNamespace`.
The renaming was done to prevent naming collisions between the class, and the
global object.
Further readings:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Public_class_fields#browser_compatibility
Signed-off-by: Florian Scherf <mail@florianscherf.de>
Codecov ReportBase: 68.52% // Head: 68.58% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #335 +/- ##
==========================================
+ Coverage 68.52% 68.58% +0.05%
==========================================
Files 68 68
Lines 5163 5163
Branches 1163 1163
==========================================
+ Hits 3538 3541 +3
+ Misses 1349 1347 -2
+ Partials 276 275 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Thanks a lot @fscherf for your fast fix! I can verify that it works fine on my iPhone 6 now. |
|
@markusgritsch: I released 1.12.3, so you can use the fix in your project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes public class fields from both JavaScript clients, because this feature is not supported in Safari<14.1.
This produced issues on iPhone 6 and iPad mini 2, reported by @markusgritsch in #334.