Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instance-maanger): add ldflags when building instance manager #1042

Conversation

ChanYiLin
Copy link
Contributor

@ChanYiLin ChanYiLin commented Mar 6, 2024

ref: longhorn/longhorn#8094

  1. We are now checking out latest instance-manager when buiding instance-manager inside longhorn-engine here
  2. When users manually exec longhorn-instance-manager inside longhorn-engine image, they will encounter
longhorn-instance-manager: error while loading shared libraries: libqcow.so.1: cannot open shared object file: No such file or directory
  1. Fixed it by adding ldflags so the binary can find the lib
  2. Since we validate engine binary path here, we have to soft link the binary inside the container to the tmp path, so the manual script can work.

innobead
innobead previously approved these changes Mar 12, 2024
@innobead
Copy link
Member

@mergify backport v1.6.x

Copy link

mergify bot commented Mar 12, 2024

backport v1.6.x

🟠 Waiting for conditions to match

  • merged [📌 backport requirement]

ref: longhorn/longhorn 8094

Signed-off-by: Jack Lin <jack.lin@suse.com>
@ChanYiLin ChanYiLin force-pushed the LH8094_fix_lib_issue_of_instance_manager branch from ae5c17f to 2039fcd Compare March 12, 2024 09:33
@ChanYiLin
Copy link
Contributor Author

ChanYiLin commented Mar 12, 2024

Our integration test intentionally test creation with invalid binary
Under current implementation, we won't return grpc error, instead we show the process status as failed and unregister the process
So we can modify the test and only validate the process list is empty in integration test

@innobead
Copy link
Member

@ChanYiLin PR check failed. Need to fix it.

@ChanYiLin
Copy link
Contributor Author

I don't know why this PR is disconnected with my branch
I can update the commit here by pushing new commit to my branch
I will recreate one

@ChanYiLin ChanYiLin closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants