fix(backup): skip loading the backingFile when doing backup or when user requests exporting the volume without backingFile #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doing more testing |
|
Hi @PhanLe1010 Can we then remove the |
ChanYiLin
reviewed
Aug 13, 2024
ChanYiLin
reviewed
Aug 13, 2024
derekbit
reviewed
Aug 13, 2024
PhanLe1010
force-pushed
the
9209
branch
2 times, most recently
from
13ff938 to
bc499c8
Compare
…ser request exporting the volume without backingFile longhorn-9209 Signed-off-by: Phan Le <phan.le@suse.com>
|
Can you help with the testing @ChanYiLin ? |
PhanLe1010
changed the title
|
@PhanLe1010 sure no problem! |
|
Thanks @ChanYiLin for building the image I did some manual test and it passed on sle-micro ARM64 I will rely on you for the rest of the work. Thank you |
Test
|
Test
|
derekbit
approved these changes
Aug 13, 2024
|
@mergify backport v1.7.x |
✅ Backports have been created |
|
@mergify backport v1.6.x v1.5.x |
✅ Backports have been created
|
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChanYiLin has awesome analysis that sometime we are still loading backing file layer on sle-micro ARM64 when doing backup link. This is not correct because we should skip loading backing file when doing backup
The current implementation relies on the assumption that file descriptor of backingFile is always 0 and uses it to skip loading the backingFile layer: link . However, this assumption is not always correct. For example, with RAW backing image,
fdis not 0. See more details at link . For qcow backing image, that assumption is correct because qcow image has hard coded to have FD 0 here https://github.com/longhorn/longhorn-engine/blob/04c645097a4a93e46f0f0391222895ea06b25456/pkg/qcow/libqcow.go#L84-L87This PR propose a this fix which always skip loading backingFile and doesn't rely on the assumption that backing file has
fdas0longhorn/longhorn#9209