feat(camera): wide zoom cameras in custom camera #948
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey again @longitachi, thanks for reviewing my previous PRs, here is another one.
This PR introduces a new feature to the
ZLCustomCamera
that allows users to utilize wide cameras (e.g., .builtInTripleCamera, .builtInDualWideCamera, .builtInDualCamera). This enhancement is designed to improve the flexibility and functionality of the camera, especially for users who need to capture wider shots. And it's also a feature that exists in the originalUIImagePickerController
but is missing inZLCustomCamera
.Key Changes
Added a new boolean property
enableWideCameras
toZLCameraConfiguration
.Updated the getCamera method in
ZLCustomCamera
to include thecameraConfig.enableWideCameras
flag check along with the #available check.Modified the
setInitialZoomFactor
method inZLCustomCamera
to use an early return with the guard statement ifcameraConfig.enableWideCameras
is false.Enhanced the
setVideoZoomFactor
method inZLCustomCamera
to use the new implementation only ifcameraConfig.enableWideCameras
is true. Otherwise, it uses the original implementation.Benefits
Flexibility: This feature allows users to take advantage of wide cameras, providing more options for capturing photos and videos.
User Experience: Users can now capture wider shots, which is especially useful for landscape photography, group photos, and more.
Non-Breaking Change
This change is non-breaking and does not affect existing functionality. The wide camera feature is disabled by default and can be enabled by setting the
enableWideCameras
parameter to true.Please review the changes and let me know if there are any adjustments or additional features you would like to include. Thank you!