-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TabPanel): Added tabStop boolean prop to TabPanel #2413
Conversation
There's an argument to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer not to ask developers to understand tabIndex
and instead offer a more semantic prop. See proposed change.
Co-authored-by: Luke Bowerman <34253496+lukelooker@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming @jhardy's research supports this I'm happy with it :)
I dug in a bit more and this seems to align closely with some updated guidance from the w3c aria best practices. This is not published on their official docs just yet, but the new guidance is for the
I am wondering about the prop name
Not sure if those are any better or too verbose, but just a few early morning thoughts. |
Great point on naming... what about |
that works for me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
In the new Field Picker experience, a keyboard user has to tab from the
Tab
to theTabPanel
to the firstTree
in order to focus on theTree
items and begin field keyboard traversal. Ideally, I think it'd be cleaner to just tab from theTab
directly to theTreeCollection
since it is the only element in theTabPanel
.Adding
tabIndex
as a prop allows devs to pass a non-zero value toTabPanel
'stabIndex
prop and thus remove it from the tab flow.Developer Checklist ℹ️