Feature/310 add invoke tasks for development #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datamance
suggested changes
Aug 8, 2019
|
I merged quite a few branches into develop, so it looks like you'll need to resolve some conflicts in the dependency files. Thankfully, this should be pretty easy :) it's not like you need to mess around with actual code. |
Datamance
suggested changes
Aug 9, 2019
Datamance
reviewed
Aug 16, 2019
Datamance
approved these changes
Aug 16, 2019
There was a problem hiding this comment.
This has my stamp of approval. I have a few more nitpicks - address those, merge your changes, and we're all good to go.
Congratulations! This was a lot of great work - I'm really looking forward to seeing you and Mayowa present this stuff at the Python Boston meetup!
tasks.py
Outdated
|
|
||
| if PLATFORM == "Linux": | ||
| # Installing graphviz | ||
| """ |
There was a problem hiding this comment.
It's ok for this to be commented out for now but let's delete this if it's not being used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to issue #310