Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to eslint 4 #408

Closed
jannyHou opened this issue Jan 12, 2018 · 3 comments
Closed

Update to eslint 4 #408

jannyHou opened this issue Jan 12, 2018 · 3 comments
Assignees
Labels

Comments

@jannyHou
Copy link
Contributor

Description:

The eslint in this repo is too old and causes lots of conflict when coding in es6 style, http://loopback.io/doc/en/contrib/style-guide.html

Upgrade to

"eslint": "^4.13.1",
"eslint-config-loopback": "^10.0.0",

And get CI pass.

@jannyHou jannyHou mentioned this issue Jan 12, 2018
2 tasks
@jannyHou jannyHou self-assigned this Jan 12, 2018
@dhmlau
Copy link
Member

dhmlau commented Mar 2, 2018

with the current version of eslint, is the CI failing?

@stale
Copy link

stale bot commented May 1, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 1, 2018
@stale
Copy link

stale bot commented May 15, 2018

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

@stale stale bot closed this as completed May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants