Alias find as findById #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannyHou
requested review from
b-admike,
dhmlau,
kjdelisle and
virkt25
as code owners
jannyHou
force-pushed
the
feat/alias-findById
branch
2 times, most recently
from
d405213
to
1f7d905
Compare
jannyHou
force-pushed
the
feat/alias-findById
branch
from
1f7d905
to
0f9b573
Compare
b-admike
approved these changes
Jan 11, 2018
|
@slnode test please |
bajtos
approved these changes
Jan 12, 2018
| // License text available at https://opensource.org/licenses/MIT | ||
|
|
||
| // This test written in mocha+should.js | ||
| var should = require('./init.js'); |
There was a problem hiding this comment.
Please use const, see http://loopback.io/doc/en/contrib/style-guide.html#variable-declarations
(According to package.json, we support only Node.js 4.x and newer, therefore const is allowed.)
There was a problem hiding this comment.
I addressed the feedback but causes eslint failure, its version is too old in this repo and a upgrading causes 100+failures and could not be fixed by running a --fix command, so I reverted the change and opened an issue for eslint upgrade:
#408
I am extremely willing to dig more but don't get too much time for it due to the interrupt issue and my lb-next process is too behind, will get back to it when everything's on the right track. Sorry for that.
| var should = require('./init.js'); | ||
|
|
||
| describe('connector function - findById', function() { | ||
| var db, TestAlias, sampleId; |
jannyHou
force-pushed
the
feat/alias-findById
branch
from
2d6fef0
to
0f9b573
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some connectors call the function that finds instance by id as
findonly but some call it asfindByIdonly, I am unifying them asfindByIdacross all connectors.Related issues
loopbackio/loopback-datasource-juggler#1459
Checklist
guide