-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alias find as findById #407
Conversation
d405213
to
1f7d905
Compare
1f7d905
to
0f9b573
Compare
@slnode test please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
// License text available at https://opensource.org/licenses/MIT | ||
|
||
// This test written in mocha+should.js | ||
var should = require('./init.js'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use const
, see http://loopback.io/doc/en/contrib/style-guide.html#variable-declarations
(According to package.json, we support only Node.js 4.x and newer, therefore const
is allowed.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I addressed the feedback but causes eslint failure, its version is too old in this repo and a upgrading causes 100+failures and could not be fixed by running a --fix
command, so I reverted the change and opened an issue for eslint upgrade:
#408
I am extremely willing to dig more but don't get too much time for it due to the interrupt issue and my lb-next process is too behind, will get back to it when everything's on the right track. Sorry for that.
var should = require('./init.js'); | ||
|
||
describe('connector function - findById', function() { | ||
var db, TestAlias, sampleId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use let
, not var
.
2d6fef0
to
0f9b573
Compare
Description
Some connectors call the function that finds instance by id as
find
only but some call it asfindById
only, I am unifying them asfindById
across all connectors.Related issues
loopbackio/loopback-datasource-juggler#1459
Checklist
guide