Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fetch unique index information for models #2316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: fetch unique index information for models #2316

wants to merge 1 commit into from

Conversation

aaqilniz
Copy link
Contributor

@aaqilniz aaqilniz commented Oct 13, 2024 •
edited
Loading

At this point, the models have no information on indexes. This PR fetches index information for models.

Related PR:

PR@loopback-connector-mysql

Checklist

  • Sign off your commits with DCO (Developer Certificate of Origin)
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@coveralls
Copy link

coveralls commented Oct 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11427526397

Details

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 84.718%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/datasource.js 5 7 71.43%
Totals Coverage Status
Change from base Build 11322400101: 0.003%
Covered Lines: 7284
Relevant Lines: 8290
💛 - Coveralls

@aaqilniz aaqilniz changed the title feat: fetch index information for models feat: fetch unique index information for models Oct 15, 2024
@aaqilniz aaqilniz mentioned this pull request Oct 20, 2024
Open
5 tasks
@aaqilniz
feat: fetch index information for models
da6ecc9 
Signed-off-by: Muhammad Aaqil <aaqilcs102@gmail.com>
@aaqilniz aaqilniz marked this pull request as ready for review October 20, 2024 15:52
@aaqilniz aaqilniz requested a review from dhmlau as a code owner October 20, 2024 15:52
@aaqilniz aaqilniz mentioned this pull request Oct 20, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhmlau dhmlau Awaiting requested review from dhmlau dhmlau is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaqilniz @coveralls