refactor: Update Get operation.

BREAKING CHANGE: yes
loophp · Oct 7, 2020 · b761ce7 · b761ce7
1 parent a99e72a
commit b761ce7
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/spec/loophp/collection/CollectionSpec.php b/spec/loophp/collection/CollectionSpec.php
@@ -887,11 +887,11 @@ public function it_can_get(): void
     {
         $this::fromIterable(range('A', 'E'))
             ->get(4)
-            ->shouldReturn('E');
+            ->shouldIterateAs(['E']);
 
         $this::fromIterable(range('A', 'E'))
             ->get('unexistent key', 'default')
-            ->shouldReturn('default');
+            ->shouldIterateAs(['default']);
     }
 
     public function it_can_get_an_iterator(): void

diff --git a/src/Collection.php b/src/Collection.php
@@ -497,9 +497,9 @@ static function (string $string, string $delimiter): Generator {
         );
     }
 
-    public function get($key, $default = null)
+    public function get($key, $default = null): CollectionInterface
     {
-        return $this->pipe(Get::of()($key)($default))->getIterator()->current();
+        return $this->pipe(Get::of()($key)($default));
     }
 
     public function getIterator(): ClosureIterator

diff --git a/src/Contract/Operation/Getable.php b/src/Contract/Operation/Getable.php
@@ -4,6 +4,8 @@
 
 namespace loophp\collection\Contract\Operation;
 
+use loophp\collection\Contract\Collection;
+
 /**
  * @psalm-template TKey
  * @psalm-template TKey of array-key
@@ -20,8 +22,7 @@ interface Getable
      * @param mixed $default
      * @psalm-param T|null $default
      *
-     * @return mixed
-     * @psalm-return T|null
+     * @psalm-return \loophp\collection\Contract\Collection<TKey, T|null>
      */
-    public function get($key, $default = null);
+    public function get($key, $default = null): Collection;
 }