Update Filter operation.
#126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: yes
drupol
force-pushed
the
refactor-update-filter-operation
branch
from
330bb4f to
2be47c8
Compare
AlexandruGG
reviewed
Jul 6, 2021
| */ | ||
| static function (Iterator $iterator) use ($callbacks): Iterator { | ||
| static function (Iterator $iterator) use ($callbacks): Generator { | ||
| // TODO: Find a way to avoid repeating this everywhere. |
There was a problem hiding this comment.
I just noticed this pattern in the other operations now that you commented this 😄.
This can't be an operation by itself so where could we put it 🤔. Maybe in AbstractOperation or on a trait?
There was a problem hiding this comment.
Dunno yet, but it's going to be a follow up for sure.
There was a problem hiding this comment.
I was going to bring up the fact that we should aim to look at solving some of the TODOs in the codebase 😁
AlexandruGG
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the operations having variadic arguments evaluates as logical
OR, the filter operation should also follow that rule.BREAKING CHANGE: yes
This PR
Related to #123 and #125