Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Map to only take a single callback #134

Merged
merged 1 commit into from
Jul 11, 2021

Conversation

AlexandruGG
Copy link
Collaborator

This PR:

  • Updates Map to only take a single callback
  • It breaks backward compatibility
  • Has unit tests (phpspec)
  • Has static analysis tests (psalm, phpstan)
  • Has documentation

Follows #112.
Related to #77.

@AlexandruGG AlexandruGG marked this pull request as ready for review July 11, 2021 17:03
@AlexandruGG
Copy link
Collaborator Author

@drupol 5.0 hype:

5 0_hype

@drupol
Copy link
Collaborator

drupol commented Jul 11, 2021

🤣 94f

@drupol drupol merged commit 365d020 into master Jul 11, 2021
@drupol drupol deleted the feature/map-single-callback branch July 11, 2021 18:09
@drupol
Copy link
Collaborator

drupol commented Jul 11, 2021

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants