Update Span and Partition operations.

[drupol]

This PR:

• Fix Show partition failure #147
• Fix Span operation which is having the same issue
• Has static analysis tests (psalm, phpstan)

[drupol]

@AlexandruGG Let me know what you think. I think this is clearly an improvement.

[AlexandruGG]

@drupol hey, so if I understand correctly the main issue is that fromCallable should be used whenever you want to instantiate the Collection from a Generator, right? And then it means that this example is kind of expected behaviour due to how PHP Generators work, right?

I'm thinking I can update the documentation to mention this and fix the static analysis as well

[drupol]

Yes exactly, and it make sense actually, I don't know why I haven't though about this earlier.

[AlexandruGG]

Yes exactly, and it make sense actually, I don't know why I haven't though about this earlier.

Cool 😄. I thought about it at first but then I also was assuming that with Collection and ClosureIterator we want to still allow that. But it makes sense to keep it consistent with how a Generator would work by itself

[AlexandruGG]

Leave this to me, I'll fix the static analysis and update the docs

[drupol]

Yes exactly, and it make sense actually, I don't know why I haven't though about this earlier.

Cool 😄. I thought about it at first but then I also was assuming that with Collection and ClosureIterator we want to still allow that. But it makes sense to keep it consistent with how a Generator would work by itself

As a closure is the real immutable thing in PHP, we must use and abuse them 💪

[drupol]

Leave this to me, I'll fix the static analysis and update the docs

Thanks :) and ok, I don't touch this anymore.

[drupol]

@drupol hey, so if I understand correctly the main issue is that fromCallable should be used whenever you want to instantiate the Collection from a Generator, right? And then it means that this example is kind of expected behaviour due to how PHP Generators work, right?

Yes ! We could imagine fixing it by detecting if the iterable is a Generator, and then wrap it in a CachingIterator. We should tackle that in another PR anyway, see #150.

[AlexandruGG]

don't forget to update these when changing method signatures 😬
#146

[drupol]

Oops! Thanks!

[AlexandruGG]

This should be good to go. Here's what I did:

• updated docs to mention the Generator behaviour. We can further update once feat: Add ::fromGenerator constructor. #150 is ready
• fixed static analysis - required being a bit more verbose in the Collection.php methods and in the operations but works
• moved the new tests into the existing partition test

[drupol]

A nice one done! And a good lesson learned :)

[drupol]

Thanks for the help @AlexandruGG !

[AlexandruGG]

Thank you for fixing this 🚀