Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/update Span and Partition in point-free #175

Merged
merged 5 commits into from
Aug 5, 2021
Merged

Refactor/update Span and Partition in point-free #175

merged 5 commits into from
Aug 5, 2021

Conversation

drupol
Copy link
Collaborator

@drupol drupol commented Aug 5, 2021 •
edited
Loading

This PR:

  • Rewrite Partition operation in point free style and without local variables.
  • Rewrite Span operation in point free style and without local variables.
  • Fix typing information of TakeWhile and DropWhile

@drupol drupol changed the title Refactor/update Span in point-free Refactor/update Span and Partition in point-free Aug 5, 2021
@drupol drupol force-pushed the refactor/update-span-operation-in-point-free branch from 24b93ac to 85a4d49 Compare August 5, 2021 10:22
@drupol drupol marked this pull request as ready for review August 5, 2021 10:25
@drupol drupol requested a review from AlexandruGG August 5, 2021 10:25
@drupol drupol added the enhancement New feature or request label Aug 5, 2021
@drupol drupol enabled auto-merge (squash) August 5, 2021 10:25
AlexandruGG
AlexandruGG reviewed Aug 5, 2021
View reviewed changes
src/Operation/Span.php Outdated Show resolved Hide resolved
@drupol drupol merged commit 0b5fede into master Aug 5, 2021
@drupol drupol deleted the refactor/update-span-operation-in-point-free branch August 5, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandruGG AlexandruGG AlexandruGG approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drupol @AlexandruGG