refactor: Update Duplicate and Distinct operations in point free style.
#188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drupol
changed the title
Duplicate and Distinct operation in point free style.Duplicate and Distinct operations in point free style.
drupol
force-pushed
the
refactor/update-duplicate-and-distinct-operation
branch
2 times, most recently
from
5e04df8 to
dff7e1b
Compare
drupol
force-pushed
the
refactor/update-duplicate-and-distinct-operation
branch
from
48ebab7 to
62ae8b5
Compare
drupol
force-pushed
the
refactor/update-duplicate-and-distinct-operation
branch
2 times, most recently
from
189c5ce to
4cab31c
Compare
AlexandruGG
reviewed
Aug 26, 2021
| Filter::of()($filterCallbackBuilder($column)), | ||
| (new Filter())()($filterCallbackBuilder($column)), |
There was a problem hiding this comment.
are these changes because you're looking to remove of() ?
There was a problem hiding this comment.
Yes, those are harmless, the typing and performance are even improved when we remove them.
AlexandruGG
approved these changes
Aug 26, 2021
…uctor. Special treatment for `Collapse` operation.
drupol
force-pushed
the
refactor/update-duplicate-and-distinct-operation
branch
from
4cab31c to
8823d18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Duplicateoperation.Distinctoperation.