Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use loophp/iterators #228

Merged
merged 6 commits into from
Dec 19, 2021
Merged

Use loophp/iterators #228

merged 6 commits into from
Dec 19, 2021

Conversation

drupol
Copy link
Collaborator

@drupol drupol commented Dec 15, 2021 •
edited
Loading

This PR:

  • Use loophp/iterators for providing ClosureIterator and IterableIterator.
  • Get rid of ProxyIterator class.
  • Get rid of ArrayCacheIterator - replaced with a better implementation in loophp/iterators.
  • Update Pack operation, use PackIterableAggregator.
  • Iterators are no more implementing OuterIterator, it was not needed anywhere.

Related to #227

@drupol drupol force-pushed the refactor/use-loophp-iterators branch 2 times, most recently from 334f0ff to e942896 Compare December 15, 2021 19:36
@drupol drupol requested a review from AlexandruGG December 15, 2021 19:39
@drupol drupol added the enhancement New feature or request label Dec 15, 2021
@drupol drupol force-pushed the refactor/use-loophp-iterators branch from e942896 to 46a745c Compare December 15, 2021 19:39
@drupol drupol mentioned this pull request Dec 16, 2021
Merged
9 tasks
@drupol drupol force-pushed the refactor/use-loophp-iterators branch 4 times, most recently from 5cfa92b to dc1ecad Compare December 18, 2021 16:19
@drupol drupol force-pushed the refactor/use-loophp-iterators branch from 77aa6b1 to 276da8c Compare December 19, 2021 19:18
AlexandruGG
AlexandruGG approved these changes Dec 19, 2021
View reviewed changes
Copy link
Collaborator

@AlexandruGG AlexandruGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@drupol drupol merged commit bc8af65 into master Dec 19, 2021
@drupol drupol deleted the refactor/use-loophp-iterators branch December 19, 2021 22:07
@drupol
Copy link
Collaborator Author

drupol commented Dec 19, 2021

Thanks @AlexandruGG !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexandruGG AlexandruGG AlexandruGG approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drupol @AlexandruGG