refactor: unfold constructor is not variadic anymore
#269
Conversation
|
drupol
force-pushed
the
refactor/unfold-constructor
branch
2 times, most recently
from
335b3ec to
e742c22
Compare
| * @param callable((T|U) ...): list<T> $callback | ||
| * @param array<int, U> $parameters |
There was a problem hiding this comment.
so does this mean that now in $parameters we want to be able to pass values of different types? What would be a good use case for that?
There was a problem hiding this comment.
Yes we could potentially do that, but T might also be the same as U.
There was a problem hiding this comment.
I gave a second look yesterday and you are perfectly right. I reverted some of the changes.
It's ready again for review.
drupol
force-pushed
the
refactor/unfold-constructor
branch
2 times, most recently
from
00af91e to
3628b2f
Compare
drupol
force-pushed
the
refactor/unfold-constructor
branch
from
3628b2f to
d424e71
Compare
| interface Unfoldable | ||
| { | ||
| /** | ||
| * Create a collection by yielding from a callback with an initial value. | ||
| * | ||
| * @see https://loophp-collection.readthedocs.io/en/stable/pages/api.html#unfold | ||
| * | ||
| * @template T | ||
| * @template U of T |
There was a problem hiding this comment.
I'm not sure why this is needed - doesn't it work if we leave it like before, just T ? Either way I guess it's the same thing
There was a problem hiding this comment.
Nope it doesn't work. This is a static function, so, U must be defined locally at the method level. And U is going to be made of T.
This PR:
Follows #. Related to #. Fixes #.