-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IsNotEmpty
operation
#292
IsNotEmpty
operation
#292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Thanks for the PR, everything seems ok, I don't have much to say.
However, there's one missing thing.
Since we include a CollectionDecorator
, you need to add the new method in it as well.
Once that issue and the other minor inline comment are done, I'll wait 24h before merging it, so @AlexandruGG is able to review it as well.
Once again, thanks for taking the time to do that !
PS: Do not mind the static analysis issues with PSalm, we are working on it in #287
@ktrzos Are you at ease with the requested changes? Feel free to ask more info if needed! |
Sorry. Didn't have much time during the last days. But things are fixed now 🙂. |
It's super fine, no worries. Thanks for fixing it ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! 👍
A couple of minor comments - I'll approve but please update the docs accordingly.
@AlexandruGG |
Thanks !!! I hope it was not too complex! Feel free to come up with new additions! |
This PR:
IsNotEmpty
operationRelated to #291.