Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix light color code everywhere where it was white #312

Merged
merged 1 commit into from
Nov 11, 2023
Merged

docs: fix light color code everywhere where it was white #312

merged 1 commit into from
Nov 11, 2023

Conversation

Curryed
Copy link
Contributor

@Curryed Curryed commented Nov 10, 2023

This PR:

  • [x ] Fixes another white code block over light gray bg

I spotted another place where it's the case. I didn't want to over do it and change everything at one, so now we can change this too!
image

@Curryed Curryed requested a review from drupol as a code owner November 10, 2023 13:40
@what-the-diff What The Diff
Copy link

what-the-diff bot commented Nov 10, 2023

PR Summary

  • Text Color Adjustment in highlight.css
    The color of the text in the specific webpage section controlled by highlight.css file has been updated. Previously, this text was appearing in white, which might have been less visible for some users. Now, it is changed to a shade of green (#1e4d06), improving the contrast and thus readability for users.

drupol
drupol approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@drupol drupol enabled auto-merge (squash) November 10, 2023 13:41
@drupol
Copy link
Collaborator

drupol commented Nov 11, 2023

Could you amend an empty commit and force push to trigger the CI ? It seems there was an issue yesterday.

auto-merge was automatically disabled November 11, 2023 13:43

Head branch was pushed to by a user without write access

@Curryed Curryed force-pushed the fix/change-text-color-from-white branch from 0ba423d to 5d1fa54 Compare November 11, 2023 13:43
@Curryed
Copy link
Contributor Author

Curryed commented Nov 11, 2023

Could you amend an empty commit and force push to trigger the CI ? It seems there was an issue yesterday.

Done! 🤞

@drupol drupol enabled auto-merge (squash) November 11, 2023 14:15
@drupol drupol disabled auto-merge November 11, 2023 14:26
@drupol drupol merged commit 0ca96c8 into loophp:master Nov 11, 2023
1 check passed
@drupol
Copy link
Collaborator

drupol commented Nov 11, 2023

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Curryed @drupol