Feature: Add Squash operation #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 15, 2021
Closed
drupol
force-pushed
the
feat-add-squash-operation
branch
from
2424ef3 to
a10e2ab
Compare
AlexandruGG
reviewed
May 15, 2021
|
Ready for another review. |
AlexandruGG
reviewed
May 16, 2021
| @@ -712,6 +712,11 @@ public function split(int $type = Operation\Splitable::BEFORE, callable ...$call | |||
| return new self(Split::of()($type)(...$callbacks), $this->getIterator()); | |||
| } | |||
|
|
|||
| public function squash(): CollectionInterface | |||
| { | |||
| return self::fromIterable($this->pack()->all())->unpack(); | |||
There was a problem hiding this comment.
If you need I can help adding the docs for this method, but would just like to understand a bit better how this works. I'm looking at the docs for pack and unpack but still don't get why they're needed here 😓.
If you don't mind can you explain what's the difference between this and doing the below?
return self::fromIterable($this->all());There was a problem hiding this comment.
I suspect it has to do with the collections allowing keys that are not only int|string as well as duplicate keys, right?
There was a problem hiding this comment.
Yes exactly. iterator_to_array() will fail if keys are different from int|string.
|
Ready for the last review! |
drupol
force-pushed
the
feat-add-squash-operation
branch
from
1141c77 to
80659f7
Compare
drupol
force-pushed
the
feat-add-squash-operation
branch
from
80659f7 to
34020ae
Compare
AlexandruGG
approved these changes
May 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Follows #82.
Related to #80.
Fixes #80.