Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API Documentation II #86

Merged
merged 19 commits into from
May 19, 2021
Merged

Update API Documentation II #86

merged 19 commits into from
May 19, 2021

Conversation

AlexandruGG
Copy link
Collaborator

@AlexandruGG AlexandruGG commented May 16, 2021 •
edited
Loading

Adding more examples and some clarifications to the API documentation.

I'm aiming to go through the whole document in this PR so I will keep it as draft until I've done so:

  • Check methods down to 'h'
  • Check methods 'h' -> 'o'
  • Check methods 'p' -> 'z'

drupol
drupol reviewed May 16, 2021
View reviewed changes
docs/pages/api.rst Outdated Show resolved Hide resolved
drupol
drupol reviewed May 16, 2021
View reviewed changes
docs/pages/api.rst Outdated Show resolved Hide resolved
drupol
drupol reviewed May 16, 2021
View reviewed changes
docs/pages/api.rst Outdated Show resolved Hide resolved
AlexandruGG and others added 4 commits May 16, 2021 22:13
@AlexandruGG @drupol
Use backticks
ad847e3 
Co-authored-by: Pol Dellaiera <pol.dellaiera@protonmail.com>
@AlexandruGG @drupol
More backticks
bbcf4cc 
Co-authored-by: Pol Dellaiera <pol.dellaiera@protonmail.com>
Update methods including "P"
5b4be7f
Merge branch 'feature/more-update-docs' of https://github.com/Alexand…
50dac77 
…ruGG/collection into feature/more-update-docs
AlexandruGG
AlexandruGG commented May 17, 2021
View reviewed changes
docs/pages/api.rst Outdated Show resolved Hide resolved
@AlexandruGG AlexandruGG marked this pull request as ready for review May 19, 2021 11:09
drupol
drupol approved these changes May 19, 2021
View reviewed changes
Copy link
Collaborator

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a work !!! Thanks !!!!!!!!!

@drupol drupol merged commit 7f10309 into loophp:master May 19, 2021
@AlexandruGG
Copy link
Collaborator Author

What a work !!! Thanks !!!!!!!!!

Thank you! It's been fun to dive into the API of this. Stay tuned for more! 😁

Btw this syntactic sugar is probably one of the best "small things" I've seen in PHP recently 😄 . Kudos to you for that!

@AlexandruGG AlexandruGG deleted the feature/more-update-docs branch May 19, 2021 12:38
@drupol
Copy link
Collaborator

drupol commented May 19, 2021

I'm glad you like it and I can't wait to get more feedback!

Btw this syntactic sugar is probably one of the best "small things" I've seen in PHP recently smile . Kudos to you for that!

This is indeed very helpful :) Thanks for your feedback, comments and contributions!

@AlexandruGG AlexandruGG mentioned this pull request May 20, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexandruGG @drupol