Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deadlock calling Event in after-event callback when current state == dst #104

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Deadlock calling Event in after-event callback when current state == dst #104

merged 2 commits into from
Feb 13, 2024

Conversation

kuzmig
Copy link
Contributor

@kuzmig kuzmig commented Feb 7, 2024

Fix for #102
Deadlock happens in case when new transition is initiated in after-event callback for dst == src

@kuzmig
Copy link
Contributor Author

kuzmig commented Feb 7, 2024

Hi @maxekman,
Can you please review this?

@kuzmig
Copy link
Contributor Author

kuzmig commented Feb 13, 2024

Hi @maxekman ,
Did you have a chance to take a look at this PR?

@coveralls
Copy link

Coverage Status

coverage: 92.711% (+0.07%) from 92.644%
when pulling 9c9eb18 on kuzmig:main
into e668a85 on looplab:main.

maxekman
maxekman approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@maxekman maxekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. I was away, thus the delay. 🙂

@maxekman maxekman merged commit b2f0ab5 into looplab:main Feb 13, 2024
1 check passed
@kuzmig
Copy link
Contributor Author

kuzmig commented Feb 13, 2024

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxekman maxekman maxekman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuzmig @coveralls @maxekman