Fix cyclonedds build for darwin #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, cyclonedds already builds fine on Linux, so it is not necessary to set |
|
Yes, it seems that this PR now is pointless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is impossible to build https://github.com/lopsided98/nix-ros-overlay/blob/master/distros/foxy/cyclonedds/default.nix since it is CMake project which is configured with
-DCMAKE_SKIP_BUILD_RPATH=ON. It breaks this calls: https://github.com/ros2-gbp/cyclonedds-release/blob/release/foxy/cyclonedds/docs/CMakeLists.txt#L22-L25 (This issue describes why it happens: NixOS/nixpkgs#22060) and thus package build at least on darwin with new CMake.Suggested changes fixes build for darwin and maybe for linux (didn't test it).