Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beacons have wrong settings #132

Closed

Conversation

gregbreen
Copy link

@gregbreen gregbreen commented Nov 2, 2021

This solves the problem of devices not receiving beacons (as discussed in #129 ). Per the regional parameters specs for 1.0.3 and 1.1 beacon radio frames should:

  • have a preamble of 10 symbols
  • have no CRC
  • have no header
  • have non-inverted signal polarity

These are four differences compared to all other frame types. The current release has the header present, has the polarity inverted, and sends the standard 8 symbol preamble.

From the 1.0.3 spec:

image

And from the 1.0.3 regional parameters:

image

That is for AU915, but the beacon signal polarity is non-inverted in every region.

@gregbreen gregbreen changed the title Bug/beacons have wrong settings Beacons have wrong settings Nov 3, 2021
@beitler
Copy link
Contributor

beitler commented Nov 4, 2021

Thanks a lot, @gregbreen, for this contribution. This glitch will be rectified asap.

I am very sorry to tell you that I will not be able to merge your PR because the contributing guidelines for this project have not been setup yet. Also, your PR is missing little details: ral_slave also is affected and preferably txjob->addcrc of the BCN is set correctly in the s2e layer and not overwritten in the ral layer.

But be assured that this will be fixed in the next release.

Thanks again!

@gregbreen
Copy link
Author

No worries @beitler . I'm not sure I understand why the contributing guidelines is a blocker, but that's OK. I'm happy to revise the PR to get it to an acceptable level.

@beitler beitler closed this in ba4f85d Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants