Add section_id as optional parameter to firstfreesubnet Resource. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the mess.... will start again later... |
|
I think it still looks good so @pavel-z1 can you please have a look ? |
steffencircle
force-pushed
the
add_section_id_to_firstfreesubnet
branch
from
f59944e
to
c1e723c
Compare
to firstfreesubnet Resource.
steffencircle
force-pushed
the
add_section_id_to_firstfreesubnet
branch
from
c1e723c
to
205a390
Compare
|
Looks good. |
pavel-z1
approved these changes
Jan 31, 2023
|
Hi @lord-kyron , @pavel-z1 ! Really hoping to get rid of my custom binaries ! Many thanks for for effort ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
@pavel-z1 i decided to start with a new PR, since i messed up during the squashing.
As discussed earlier, this adds the
section_idparameter to the firstfreeSubnet Resource and flags it as an Optional parameter to retain backwards-compatibility.This fixes #53
I based it on-top of the current changes in the master branch and tested with those (provider sdk v2).
Can you please have a look ?
Steffen